Ability to override host for ssh attempts

[ytsarev]

Useful for complex scenarios when socket != host to access containers

[ytsarev]

My use case:

• kitchen as a tool itself is containerized
• docker.sock is mounted to kitchen container
• kitchen launches containers on host through mounted socket
• kitchen ssh to instances under test through docker bridge, so I specify
  ssh_host: 172.17.0.1 to point kitchen to docker0 bridge IP address

[clifff]

👍 I did the same thing so that I could build/test cookbooks from a Docker based CI system.

[ddaymn]

Another use case is the native docker for windows. that client does not listen on localhost but instead uses "docker"

[claudio-viola]

let's merge this please!

[rheostat]

IMHO, it would be better to do this in the SSH transport configuration so as to avoid leaking the details of the kitchen-docker transport being used. See this pull request: https://github.com/test-kitchen/test-kitchen/pull/1138/files

[ytsarev]

@rheostat I agree, it does belong to transport.

[mwasserschaff]

I have a similar use case where kitchen runs in a container and cannot ssh into the container created by kitchen-docker. I would be willing to contribute a PR to let kitchen ssh to the container's ip. However there is already the aforementioned PR pending without any activity there, so I am not sure if it is worth the efforts.