Feature: use_internal_docker_network#313
Closed
jrbeilke wants to merge 2 commits intotest-kitchen:masterfrom
Closed
Feature: use_internal_docker_network#313jrbeilke wants to merge 2 commits intotest-kitchen:masterfrom
jrbeilke wants to merge 2 commits intotest-kitchen:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
- Coverage 33.77% 32.78% -1%
=======================================
Files 2 2
Lines 228 241 +13
=======================================
+ Hits 77 79 +2
- Misses 151 162 +11
Continue to review full report at Codecov.
|
Member
|
This same functionality has been merged to master and I'll be shipping it ASAP |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yet another PR to add use_internal_docker_network feature based on @amalucelli's work in #304 as well as @AaronKalair's work in #283
Modified the container_ip method to fetch the container's .IPAddress from .NetworkSettings.Networks using docker inspect as recommended by @rs017991 and https://docs.docker.com/engine/reference/commandline/inspect/#examples
This resolves #215