update gem dependencies introduced in #340#349
Closed
yeoldegrove wants to merge 1 commit intotest-kitchen:masterfrom
Closed
update gem dependencies introduced in #340#349yeoldegrove wants to merge 1 commit intotest-kitchen:masterfrom
yeoldegrove wants to merge 1 commit intotest-kitchen:masterfrom
Conversation
Contributor
|
@yeoldegrove There have been some updates to the gemspec file since this PR was created which includes the latest version of the kitchen-inspec gem (2.0.0). Also, I'm not sure we need to include kitchen-docker gem into the dependency list of the same gem. Let me know if I'm missing something, though. I'm going to close this PR for now as we're trying to clean up older PRs and issues in this repo. If there are still updates required, please open a new PR and we can review. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The great 🎉 work in #340 introduced a few new gem dependencies.
I would vote for addin these not
development_dependency, but asdependencybecause using the newdocker transportwithout these gems will just not work.