Parse attributeless <failure> tags correctly#55
Merged
ethomson merged 1 commit intotest-summary:mainfrom Jan 15, 2025
Merged
Conversation
[`jest-junit`](https://github.com/jest-community/jest-junit) generates failure tags that have no attributes, only inner text. For example: `<failure>Failed!</failure>`. The [`xml2js`](https://www.npmjs.com/package/xml2js) library seems to produce different objects based on whether a tag has attributes. See the minimal example: ```js var parseString = require('xml2js').parseString; var print = (err, result) => console.log(JSON.stringify(result, null, 2)) var parse = (xmlStr) => parseString(xmlStr, print) parse('<a b="c">d</a>') { "a": { "_": "d", "$": { "b": "c" } } } parse('<a>d</a>') { "a": "d" } ``` Notice how the second output above is not `{"a": {"_": "d"}}` With this change, we take into account this difference while parsing the failure messages.
Member
|
Thanks for the fix! |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jest-junitgenerates failure tags that have no attributes, only inner text. For example:<failure>Failed!</failure>.The
xml2jslibrary seems to produce different objects based on whether a tag has attributes. See the minimal example:Notice how the second output above is not
{"a": {"_": "d"}}With this change, we take into account this difference while parsing the failure messages.