Skip to content

Presto: Bump default Presto version (used in deprecated constructor and unversioned JDBC URL) from 329 to 344 #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnorth merged 1 commit into from
Oct 30, 2020
Merged

Presto: Bump default Presto version (used in deprecated constructor and unversioned JDBC URL) from 329 to 344 #3312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/modules/databases/jdbc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Insert `tc:` after `jdbc:` as follows. Note that the hostname, port and database

#### Using Presto

`jdbc:tc:presto:329://localhost/memory/default`
`jdbc:tc:presto:344://localhost/memory/default`

### Using a classpath init script

Expand Down
2 changes: 1 addition & 1 deletion modules/presto/src/main/java/org/testcontainers/containers/PrestoContainer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class PrestoContainer<SELF extends PrestoContainer<SELF>> extends JdbcDat
public static final String NAME = "presto";
private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("prestosql/presto");
public static final String IMAGE = "prestosql/presto";
public static final String DEFAULT_TAG = "329";
public static final String DEFAULT_TAG = "344";

public static final Integer PRESTO_PORT = 8080;

Expand Down
4 changes: 2 additions & 2 deletions modules/presto/src/test/java/org/testcontainers/PrestoTestImages.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@
import org.testcontainers.utility.DockerImageName;

public interface PrestoTestImages {
DockerImageName PRESTO_TEST_IMAGE = DockerImageName.parse("prestosql/presto:329");
DockerImageName PRESTO_PREVIOUS_VERSION_TEST_IMAGE = DockerImageName.parse("prestosql/presto:328");
DockerImageName PRESTO_TEST_IMAGE = DockerImageName.parse("prestosql/presto:344");
DockerImageName PRESTO_PREVIOUS_VERSION_TEST_IMAGE = DockerImageName.parse("prestosql/presto:343");
}
2 changes: 1 addition & 1 deletion modules/presto/src/test/java/org/testcontainers/jdbc/presto/PrestoJDBCDriverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ public class PrestoJDBCDriverTest extends AbstractJDBCDriverTest {
public static Iterable<Object[]> data() {
return asList(
new Object[][]{
{"jdbc:tc:presto:329://hostname/", EnumSet.of(Options.PmdKnownBroken)},
{"jdbc:tc:presto:344://hostname/", EnumSet.of(Options.PmdKnownBroken)},
});
}
}