Skip to content

Use a lighter weight image for MultiplePortsExposedTest #3343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rnorth merged 2 commits into from
Oct 13, 2020
Merged

Use a lighter weight image for MultiplePortsExposedTest #3343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13ab504
Use a lighter weight image for MultiplePortsExposedTest
rnorth Oct 13, 2020
f82bb9a
Update helloworld container version
rnorth Oct 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions docs/examples/junit4/generic/src/test/java/generic/MultiplePortsExposedTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,29 @@
package generic;

import static org.slf4j.LoggerFactory.getLogger;

import org.junit.Rule;
import org.junit.Test;
import org.slf4j.Logger;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.output.Slf4jLogConsumer;
import org.testcontainers.utility.DockerImageName;

import static org.slf4j.LoggerFactory.getLogger;

public class MultiplePortsExposedTest {
private static final Logger log = getLogger(MultiplePortsExposedTest.class);


@Rule
// rule {
public GenericContainer container = new GenericContainer(DockerImageName.parse("orientdb:3.0.13"))
.withExposedPorts(2424, 2480)
public GenericContainer<?> container = new GenericContainer<>(DockerImageName.parse("testcontainers/helloworld:1.1.0"))
.withExposedPorts(8080, 8081)
.withLogConsumer(new Slf4jLogConsumer(log));
// }

@Test
public void fetchPortsByNumber() {
Integer firstMappedPort = container.getMappedPort(2424);
Integer secondMappedPort = container.getMappedPort(2480);
Integer firstMappedPort = container.getMappedPort(8080);
Integer secondMappedPort = container.getMappedPort(8081);
}

@Test
Expand All @@ -39,6 +39,6 @@ public void getHostOnly() {
@Test
public void getHostAndMappedPort() {
String address =
container.getHost() + ":" + container.getMappedPort(2424);
container.getHost() + ":" + container.getMappedPort(8080);
}
}
13 changes: 6 additions & 7 deletions modules/selenium/src/test/java/org/testcontainers/junit/BaseWebDriverContainerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
package org.testcontainers.junit;

import static java.lang.String.format;
import static org.rnorth.visibleassertions.VisibleAssertions.assertEquals;
import static org.rnorth.visibleassertions.VisibleAssertions.assertTrue;

import java.util.concurrent.TimeUnit;
import org.jetbrains.annotations.NotNull;
import org.junit.ClassRule;
import org.openqa.selenium.By;
Expand All @@ -11,12 +16,6 @@
import org.testcontainers.containers.wait.strategy.HttpWaitStrategy;
import org.testcontainers.utility.DockerImageName;

import java.util.concurrent.TimeUnit;

import static java.lang.String.format;
import static org.rnorth.visibleassertions.VisibleAssertions.assertEquals;
import static org.rnorth.visibleassertions.VisibleAssertions.assertTrue;

/**
*
*/
Expand All @@ -26,7 +25,7 @@ public class BaseWebDriverContainerTest {
public static Network NETWORK = Network.newNetwork();

@ClassRule
public static GenericContainer<?> HELLO_WORLD = new GenericContainer<>(DockerImageName.parse("testcontainers/helloworld:1.0.0"))
public static GenericContainer<?> HELLO_WORLD = new GenericContainer<>(DockerImageName.parse("testcontainers/helloworld:1.1.0"))
.withNetwork(NETWORK)
.withNetworkAliases("helloworld")
.withExposedPorts(8080, 8081)
Expand Down