Rename Docker image name and make it public#3350
Rename Docker image name and make it public#3350dadoonet wants to merge 1 commit intotestcontainers:masterfrom
Conversation
dadoonet
force-pushed
the
pr/make_images_public
branch
from
b7679d6 to
22c17ef
Compare
| } | ||
| } | ||
|
|
||
| @SuppressWarnings("deprecation") // Using deprecated constructor for verification of backwards compatibility |
There was a problem hiding this comment.
Note that this change is not related to the goal of this PR and is a leftover from #2320
It's probably better to use the same way to declare an image as we have with other modules like couchbase for example. It has also a positive "side" effect to highlight the fact that it's a good practice to set the tag when building the container.
dadoonet
force-pushed
the
pr/make_images_public
branch
from
22c17ef to
c1771fa
Compare
|
I think we might have to delay this a bit. I've put my thinking into a new issue ticket, which we need to work out: #3381 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
|
Not stale 😉 |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
| /** | ||
| * Elasticsearch Docker base image: oss distribution under Apache2 license | ||
| */ | ||
| public static final DockerImageName ELASTICSEARCH_OSS_IMAGE = DockerImageName.parse("docker.elastic.co/elasticsearch/elasticsearch-oss"); |
There was a problem hiding this comment.
This image has been removed after 7.10.2. So I believe that I should update the PR and remove entirely this field.
There was a problem hiding this comment.
Aren't images distributed over Docker Hub again?
There was a problem hiding this comment.
Nope. There's no -oss package after 7.10.2
There was a problem hiding this comment.
But there's the default distribution as it has always been 😊
|
Thanks for the PR @dadoonet ! Our current approach is not to make public those fields public. However, we have noticed an improvement in our documentation due to not all modules expose the image to be used. |
4 participants
It's probably better to use the same way to declare an image as we have with other modules like couchbase for example.
It has also a positive "side" effect to highlight the fact that it's a good practice to set the tag when building the container.