Update default Docker Hub registry name to fix Docker Desktop authentication #5263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Docker CLI uses Regarding their implementation, they likely don't have a hardcoded value anywhere (as I can see so far), but just use the value they query from another location or endpoint, but I have to continue following their implementation code, to connect all the dots there. We can likely replicate this and should become much more robust and portable in our implementation. |
Member
|
Superseeded by #5347? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seem to have been different changes around Docker Desktop, its used authentication mechanisms in conjunction with
docker-credential-desktopand the Docker Hub registry.This led to the problem, that Testcontainers would interact with
docker-credential-desktopin a way, that would provide us with wrong credentials, depending on how the Docker Hub login was performed (although this is not completely understood yet).This is an experimental fix, that tries to restore the previous behavior.
Fixes #5121