ClickHouse uses new driver if it is available and version is compatible#6236
Merged
eddumelendez merged 3 commits intotestcontainers:mainfrom Feb 1, 2023
Merged
ClickHouse uses new driver if it is available and version is compatible#6236eddumelendez merged 3 commits intotestcontainers:mainfrom
eddumelendez merged 3 commits intotestcontainers:mainfrom
Conversation
| } | ||
| } | ||
|
|
||
| private static boolean isNewDriverSupported(DockerImageName dockerImageName) { |
Member
There was a problem hiding this comment.
I think you may want to use ComparableVersion. See
Contributor
Author
There was a problem hiding this comment.
@eddumelendez Oh, that's great, thanks! Will fix it as soon as possible.
Contributor
Author
There was a problem hiding this comment.
Replaced with ComparableVersion.
Contributor
Author
|
Oh, I forgot to run |
eddumelendez
approved these changes
Feb 1, 2023
Member
|
Thanks for your contribution @trolley813 ! This is now is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A replacement for #5666 (related to the now-closed #6232). Now,
ClickHouseContainerpicks up the newcom.clickhouse.jdbc.ClickHouseDriverdriver if it is available and the version tag is 20.7 or later (as supported by the driver), otherwise it falls back to the legacyru.yandex.clickhouse.ClickHouseDriverdriver.