Skip to content

fix: update wait_for_logs to not throw on "created" #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexanderankin wants to merge 1 commit into from
Closed

fix: update wait_for_logs to not throw on "created" #716

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion core/testcontainers/core/waiting_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,9 @@ def wait_for(condition: Callable[..., bool]) -> bool:
return condition()


_NOT_EXITED_STATUSES = {"running", "created"}


def wait_for_logs(
container: "DockerContainer",
predicate: Union[Callable, str],
Expand Down Expand Up @@ -118,6 +121,6 @@ def wait_for_logs(
return duration
if duration > timeout:
raise TimeoutError(f"Container did not emit logs satisfying predicate in {timeout:.3f} " "seconds")
if raise_on_exit and container.get_wrapped_container().status != "running":
if raise_on_exit and container.get_wrapped_container().status not in _NOT_EXITED_STATUSES:
raise RuntimeError("Container exited before emitting logs satisfying predicate")
time.sleep(interval)