add 5 different python versions to test with #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
given that to support python 3.8 we would need to downgrade numpy to 1.24.4 wont downgrade it, and this means that 3.8 Python version wont be supported by Py-TestUI |
TDL-EdgarsEglitis
approved these changes
Dec 11, 2023
Collaborator
|
Does the publish workflow need similar changes? |
Contributor
Author
Since that workflow is only used to publish to pip, the python version to build the wheel doesn't really matter. It only matters in very specific cases where you have compiled C extensions, but this is not one, so all good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
right now the pipelines only test on the 3.10 version, but multiple users use from 3.8 to 3.12, so it would be nice to test those versions before merging