add 4. selenium version to get compatibility with Selenium Grid 4.

[alvarolaserna]

Right now, using selenium grid 4.14.1 Testray doesnt work, adding this upgrade will make it work.

[TDL-EdgarsEglitis]

I think this code can be simplified. It looks like Selenium::WebDriver::Remote::Capabilities is deprecated, so we could try something like this:

  def build_chrome_driver(chrome_ops)
    chromeOptions = Selenium::WebDriver::Chrome::Options.new(
      options: chrome_ops,
    )
    if @url.nil?
      # local selenium instance
      driver = Selenium::WebDriver.for(
        :chrome, options: chromeOptions,
      )
    else
      # remote selenium grid
      log_debug("Selenium Server URL: #{@url}")
      driver = Selenium::WebDriver.for(
        :remote, url: @url, options: chromeOptions,
      )
    end
    return driver
  end

The equivalent code for other browsers should be similarly adjusted.

[alvarolaserna]

I think this code can be simplified. It looks like Selenium::WebDriver::Remote::Capabilities is deprecated, so we could try something like this:

  def build_chrome_driver(chrome_ops)
    chromeOptions = Selenium::WebDriver::Chrome::Options.new(
      options: chrome_ops,
    )
    if @url.nil?
      # local selenium instance
      driver = Selenium::WebDriver.for(
        :chrome, options: chromeOptions,
      )
    else
      # remote selenium grid
      log_debug("Selenium Server URL: #{@url}")
      driver = Selenium::WebDriver.for(
        :remote, url: @url, options: chromeOptions,
      )
    end
    return driver
  end

The equivalent code for other browsers should be similarly adjusted.

I've modified it to cover that, the only one that Im not sure how to test is Safari, it doesnt seem to have any capabilities that I can try and work with... but for the rest of the browsers, everything goes as expected

[TDL-EdgarsEglitis]

Ok great - I can check it once you push the commit :)

[alvarolaserna]

Ok great - I can check it once you push the commit :)

done

[TDL-EdgarsEglitis]

We should only use Selenium::WebDriver::<browser>::Options.new

[TDL-EdgarsEglitis]

I just realised that the code can be simplified even further:

  def build_chrome_driver(chrome_ops)
    chromeOptions = Selenium::WebDriver::Chrome::Options.new(
      options: chrome_ops,
    )
    if @url.nil?
      # local selenium instance
      Selenium::WebDriver.for(
        :chrome, options: chromeOptions,
      )
    else
      build_remote_driver(chromeOptions)
    end
  end
  
  # similar methods for other browser drivers
  
  def build_remote_driver(options)
    # remote selenium grid
    log_debug("Selenium Server URL: #{@url}")
    Selenium::WebDriver.for(
      :remote, url: @url, options: options,
    )
  end

[alvarolaserna]

  def build_remote_driver(options)
    # remote selenium grid
    log_debug("Selenium Server URL: #{@url}")
    Selenium::WebDriver.for(
      :remote, url: @url, options: options,
    )
  end

Yes, this makes a lot of sense, thanks!