feat: add scroll_until_element_visible method #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alvarolaserna
left a comment
alvarolaserna
left a comment
There was a problem hiding this comment.
if I remember correctly, there is a small case under examples, that uses android. It would be nice to add a usage example there for this methods. I think it was using the playstore app
Collaborator
Author
Added a simple test scenario for this method. |
alvarolaserna
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method that automatically scrolls in the given (vertical) direction until the specified element is found. There are many configurable parameters here, which are described in the readme.
Testing was done to confirm that all the parameters are working as expected.