fix: fixes for scroll_until_element_visible #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alvarolaserna
left a comment
alvarolaserna
left a comment
There was a problem hiding this comment.
I think it is fine, but reviewing the code, I got wondering, the default timeout for the scrolling seems to be 60 seconds. I feel like we should be using the default on the global variable @timeout instead, as thats the default behaviour for alll the rest method's timouts. wdyt?
Collaborator
Author
|
Good point - I have changed that as well and reflected this in the PR title. |
TDL-EdgarsEglitis
changed the title
alvarolaserna
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with
scroll_until_element_visiblewhen usingRecheckAfterScrolls, where the scroll positions were not correctly calculated. Related to #61.