fix: prevent click action from being skipped #63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a fairly specific issue with click actions (where multiple timestamps are generated while finding the element):
If the timeout for finding the element (
Time) is specified to be longer than the timeout for clicking the element (CheckTimeor the default timeout), there may be a situation where the element search does end up taking a long time - longer than the timeout for clicking the element. This would mean that the conditionwhile (Time.now - start) < wait_timewould immediately fail, the click action would not even be attempted, and the test would continue.This PR fixes the issue by adjusting the above condition.