Merged
Conversation
wagenet
force-pushed
the
todo-support
branch
from
71843f0 to
596fb4b
Compare
wagenet
force-pushed
the
todo-support
branch
2 times, most recently
from
af9020c to
339074d
Compare
Contributor
Author
|
I've tested this against an Ember app using QUnit.todo and it works well enough for me to want to use it. Of course, I understand if there's a higher bar for merging :) |
4 tasks
step2yeung
requested changes
Feb 16, 2020
Contributor
Author
|
@step2yeung any thoughts? |
Member
|
@wagenet thanks for the ping & your patiences! Resolved 2 of the comments, also just pulling in the pr myself to see how it works :) |
step2yeung
reviewed
Mar 4, 2020
Contributor
Author
|
@step2yeung I believe the remaining failures are not my fault. |
Member
Contributor
|
Awesome, thank you both! @step2yeung - Mind shipping a release? |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently includes #1398 and #1399. Should be rebased once those are merged.
Supersedes #1101
Includes support for TAP, Dot, and dev reporters. May not work properly with other options.