Conversation
hugovk
force-pushed
the
rm-3.5
branch
2 times, most recently
from
2dda39a to
593ea89
Compare
mtreinish
left a comment
mtreinish
left a comment
There was a problem hiding this comment.
Code-wise this LGTM, but can you split this into 2 PRs, one adding 3.9 support to the package metadata (and probably most of the gha config cleanup) and the other dropping 3.5 support. I think for the next release (which should be relatively soon) we should still include 3.5 support and say in the release notes for it that 2.5.0 is the last release with 3.5 support. We haven't previously advertised dropping 3.5 before so I don't want to catch any potential 3.5 users by surprise.
|
Yep, that sounds reasonable, please see #310 for adding 3.9. After that's merged (to avoid conflicts), I'll rebase and update this one. Thanks! |
hugovk
changed the title
This comment has been minimized.
This comment has been minimized.
|
Merge conflict resolved! Is there anything more needed here? Thanks! |
|
@hugovk Can you rebase this so we can pick up new test runs? |
|
Rebased! This needs the 3.5 status check being marked as NOT required. At the same time, the new 3.10 one can be marked as required.
|
|
Updated to add a final, noop job to indicate success:
Its success depends on the build step fully passing. So instead of needing to #309 (comment) each and every time a Python version is added to or removed from the matrix, we can just add this new "test successful" as the required check. |
|
Closing this year-old PR to clear my list, happy to re-open if you want to merge :) |
|
Sorry about that. If you reopen, I promise I'll take a look at merging it. |
|
No problem, re-opened! |
|
Finally figured out how to mark the 3.5 tests as no longer required :) |
|
We probably want to do 3.6 next. I think that's EOL now too |
|
Yes, 3.6 was EOL in December 2021 (3.7 will be June 2023). |
4 participants
Also:
--py36-plus