Skip to content

Format code with ruff#370

Merged
jelmer merged 3 commits intomasterfrom
ruff-format
Dec 20, 2023
Merged

Format code with ruff#370
jelmer merged 3 commits intomasterfrom
ruff-format

Conversation

@jelmer
Copy link
Copy Markdown
Member

@jelmer jelmer commented Nov 24, 2023

No description provided.

@bigjools
Copy link
Copy Markdown
Contributor

It's a bit tragic that ruff doesn't have black's setting skip-string-normalization.

@bigjools
Copy link
Copy Markdown
Contributor

FWIW I am great with merging this but let's get a second opinion.

@jelmer
Copy link
Copy Markdown
Member Author

jelmer commented Nov 26, 2023

I'm actually quite a fan of string normalization, but could be possibly be persuaded to port skip-string-normalization to ruff.

@bigjools
Copy link
Copy Markdown
Contributor

Yeah I don't mind it too — except when you completely destroy the current git blame on a mature code base.

@jelmer
Copy link
Copy Markdown
Member Author

jelmer commented Dec 8, 2023

I'll merge sometime in 2024 if there are no objections.

@stephenfin
Copy link
Copy Markdown
Contributor

stephenfin commented Dec 11, 2023

Yeah I don't mind it too — except when you completely destroy the current git blame on a mature code base.

Just create a .git-blame-ignore-revs file. GitHub respects that and you can configure your local Git to do the same. I stick this header into the file each time I create one:

# You can configure git to automatically use this file with the following config:
# git config --global blame.ignoreRevsFile .git-blame-ignore-revs

I'm a-okay with this change also, fwiw.

@bigjools
Copy link
Copy Markdown
Contributor

Just create a .git-blame-ignore-revs file. GitHub respects that and you can configure your local Git to do the same. I stick this header into the file each time I create one:

# You can configure git to automatically use this file with the following config:
# git config --global blame.ignoreRevsFile .git-blame-ignore-revs

TIL!

@jelmer jelmer enabled auto-merge December 20, 2023 09:52
@jelmer jelmer merged commit 50075c2 into master Dec 20, 2023
@stephenfin stephenfin deleted the ruff-format branch December 21, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants