Treat methodName="runTest" similar to unittest.TestCase#373
Merged
jelmer merged 2 commits intotesting-cabal:masterfrom May 13, 2024
Merged
Treat methodName="runTest" similar to unittest.TestCase#373jelmer merged 2 commits intotesting-cabal:masterfrom
jelmer merged 2 commits intotesting-cabal:masterfrom
Conversation
ncopa
force-pushed
the
fix-pytest-8.2
branch
2 times, most recently
from
fb822a8 to
e4f0b99
Compare
jelmer
approved these changes
May 13, 2024
jelmer
requested changes
May 13, 2024
Member
jelmer
left a comment
jelmer
left a comment
There was a problem hiding this comment.
Please run ruff format, otherwise LGTM
pytest 8.2 relies on a feature of `unittest.TestCase` where the initialization of it with the default `methodName="runTest"` is treated specially, allowing it to insantiate even without `runTest` method actually existing. See under "Changed in Python 3.2" in unittest.TestCase docs This fixes the error with pytest 8.2: AttributeError: 'TestUtil' object has no attribute 'runTest'. Did you mean: 'subTest'? Fixes: testing-cabal#372 ref: https://docs.python.org/3/library/unittest.html#unittest.TestCase ref: https://github.com/python/cpython/blob/51aefc5bf907ddffaaf083ded0de773adcdf08c8/Lib/unittest/case.py#L419-L426 ref: pytest-dev/pytest#12263 (comment)
auto-merge was automatically disabled
May 13, 2024 13:26
Head branch was pushed to by a user without write access
Contributor
Author
|
ruff formatted it (I hope). sorry for that. |
jelmer
approved these changes
May 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 82. relies on a feature of
unittest.TestCasewhere the initialization of it with the defaultmethodName="runTest"is treated specially, allowing it to insantiate even withoutrunTestmethod actually existing.See under "Changed in Python 3.2" in unittest.TestCase docs
This fixes the error with pytest 8.2:
AttributeError: 'TestUtil' object has no attribute 'runTest'. Did you mean: 'subTest'?
Fixes: #372
ref: https://docs.python.org/3/library/unittest.html#unittest.TestCase
ref: https://github.com/python/cpython/blob/51aefc5bf907ddffaaf083ded0de773adcdf08c8/Lib/unittest/case.py#L419-L426
ref: pytest-dev/pytest#12263 (comment)