Remove support for Python 3.8 + deprecated methods and classes#424
Merged
jelmer merged 4 commits intotesting-cabal:masterfrom Apr 2, 2025
Merged
Remove support for Python 3.8 + deprecated methods and classes#424jelmer merged 4 commits intotesting-cabal:masterfrom
jelmer merged 4 commits intotesting-cabal:masterfrom
Conversation
Contributor
stephenfin
commented
Feb 21, 2025
stephenfin
commented
- Drop support for Python 3.8
- Remove remnants of setuptools
- Remove deprecated classes, methods
- Resolve deprecation warning
jelmer
requested changes
Feb 21, 2025
Member
jelmer
left a comment
jelmer
left a comment
There was a problem hiding this comment.
LGTM, but looks like there are some test failures.
Member
|
@stephenfin looks like it just needs to have "ruff format" run on it |
jelmer
reviewed
Feb 22, 2025
stephenfin
force-pushed
the
cleanup
branch
2 times, most recently
from
3460916 to
55b7633
Compare
Signed-off-by: Stephen Finucane <stephen@that.guru>
stephenfin
force-pushed
the
cleanup
branch
2 times, most recently
from
5e79be6 to
9c9a2ff
Compare
We also move stuff around pyproject.toml to keep related things together and allow users to use the package without installing it or having setuptools_scm installed.. Signed-off-by: Stephen Finucane <stephen@that.guru>
Signed-off-by: Stephen Finucane <stephen@that.guru>
See [1] for more info. [1] python/cpython#79893 Signed-off-by: Stephen Finucane <stephen@that.guru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.