-
Notifications
You must be signed in to change notification settings - Fork 1.2k
docs: use "msw" for API mocking in examples #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I've also split the two code blocks, assuming there's been a typo and they were merged together by mistake (they showcase two different files). Please let me know if that was intentional, I'll revert the change. Thanks! |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a282e4:
|
Codecov Report
@@ Coverage Diff @@
## master #697 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 100 100
Branches 16 16
=========================================
Hits 100 100 Continue to review full report at Codecov.
|
kentcdodds
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👍
|
@all-contributors please add @kettanaito for docs |
|
I've put up a pull request to add @kettanaito! 🎉 |
|
🎉 This PR is included in version 10.2.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
@kentcdodds, thanks for the review! Honored to be a part of this! |
What:
Uses
mswlibrary for API mocking in the test suite example in README.Why:
These changes are implemented similar to the React Example from the Testing Library documentation.
How:
setupServerserver.use(), allowing to test an error scenarioChecklist:
docs site