Upgrade to webdriverio 9, @testing-library/dom 10#54
Open
sventschui wants to merge 3 commits intotesting-library:mainfrom
Open
Upgrade to webdriverio 9, @testing-library/dom 10#54sventschui wants to merge 3 commits intotesting-library:mainfrom
sventschui wants to merge 3 commits intotesting-library:mainfrom
Conversation
BREAKING CHANGE: This PR introduces compatibility with webdriverio 9 and bumps @testing-library/dom to v10. Compatibility with webdriverio 8 and previous has been removed.
Author
|
Hey @olivierwilkinson @nickserv May I ask whether you guys are still maintaining this lib? I know this is OSS and you have no obligations to do so. If you don't feel like maintaining this any longer, I will publish my own fork of this on npm. If you are, I'd be happy if you could review this PR such that we can land support for wdio v9. Thank you |
Author
|
For everyone checking this, I published the PR as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: This PR introduces compatibility with webdriverio 9 and bumps @testing-library/dom to v10. Compatibility with webdriverio 8 and previous has been removed.
Fixes #53
Fixes #52