Removes redundant test invocation and prepares for new Docker images#389
Merged
codefromthecrypt merged 1 commit intomasterfrom Oct 6, 2021
Merged
Removes redundant test invocation and prepares for new Docker images#389codefromthecrypt merged 1 commit intomasterfrom
codefromthecrypt merged 1 commit intomasterfrom
Conversation
Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
dedupe-gha
branch
from
39f70b0 to
84099cd
Compare
codefromthecrypt
changed the title
codefromthecrypt
commented
Oct 6, 2021
| docker run --rm -v $HOME/.func-e:${DOCKER_HOME}/.func-e -v $PWD:/work -w /work --entrypoint /usr/bin/make ${CENTOS_IMAGE} -o ${E2E_FUNC_E_PATH}/func-e e2e | ||
| env: # CENTOS_IMAGE was built by internal-images.yaml; E2E_FUNC_E_PATH was built via `make build` | ||
| CENTOS_IMAGE: ghcr.io/tetratelabs/func-e-internal:centos8 | ||
| E2E_FUNC_E_PATH: build/func-e_linux_amd64/func-e |
Contributor
Author
There was a problem hiding this comment.
bug as PATH is the path to func-e
| if: runner.os == 'Linux' | ||
| run: docker run -v $HOME/.func-e:/root/.func-e -v $PWD:/func-e --rm ${CENTOS_IMAGE} -c "cd /func-e; make -o ${E2E_FUNC_E_PATH} e2e" | ||
| run: | # TODO: clean this up after #387 as DOCKER_HOME, workdir and entrypoint will be correct by default | ||
| DOCKER_HOME=$(docker run --rm --entrypoint /bin/bash ${CENTOS_IMAGE} -c 'echo $HOME') |
Contributor
Author
There was a problem hiding this comment.
this line and a bunch of the overriding below go away with the new images, but this syntax will work with both old and new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prepares for #387 by looking up the homedir of the docker user
dynamically. This also deduplicates double-testing with timezone as
that's a very heavy way to avoid bugs.