Publishes internal Ubuntu Docker image#392
Merged
codefromthecrypt merged 2 commits intomasterfrom Oct 8, 2021
Merged
Conversation
This change... * adds an Ubuntu image which can be used to build distributions * ensures the image to use runner instead of root like GHA * removes go version management in travis * removes configure_go.sh Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
docker-polish
branch
from
5100584 to
f45bfa4
Compare
Contributor
Author
codefromthecrypt
commented
Oct 8, 2021
| # ``` | ||
| jobs: | ||
| build-and-push-images: | ||
| runs-on: ubuntu-20.04 # Hard-coding an LTS means maintenance, but only once each 2 years! |
Contributor
Author
There was a problem hiding this comment.
one advantage of switching to explicit versions is now the runner os version matches the docker tag
codefromthecrypt
commented
Oct 8, 2021
| virt: lxd # faster starting | ||
| language: go | ||
|
|
||
| go: # Use gimme expression to get latest patch. See https://github.com/travis-ci/gimme |
Contributor
Author
There was a problem hiding this comment.
so now, the version will be exactly the same GHA vs travis
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change...
runnerinstead ofrootlike GHA