Skip to content

Removes broken and untested Linux package signing#395

Merged
codefromthecrypt merged 1 commit intomasterfrom
remove-busted-signatures
Oct 10, 2021
Merged

Removes broken and untested Linux package signing#395
codefromthecrypt merged 1 commit intomasterfrom
remove-busted-signatures

Conversation

@codefromthecrypt
Copy link
Copy Markdown
Contributor

This didn't work at all. It was hidden because variables weren't exported, so they didn't reach nfpm.

-       @$(go) run $(nfpm) pkg -f $1 --packager $2 --target $3
+       @# $(go:go=) removes the trailing 'go', so we can insert package signing variables
+       @$(go:go=) NFPM_KEYFILE=$(NFPM_KEYFILE) NFPM_KEYID=$(NFPM_KEYID) NFPM_PASSPHRASE=$(NFPM_PASSPHRASE) \
+       go run $(nfpm) pkg -f $1 --packager $2 --target $3

We also could have noticed this if our test scripts verified signatures, which they didn't!

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@codefromthecrypt
Copy link
Copy Markdown
Contributor Author

#396 will eventually re-add this

@codefromthecrypt codefromthecrypt merged commit eca33d6 into master Oct 10, 2021
@codefromthecrypt codefromthecrypt deleted the remove-busted-signatures branch October 10, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant