Add ctrl+c twice support with shutdown hook panic recovery#473
Closed
codefromthecrypt wants to merge 2 commits into
Closed
Add ctrl+c twice support with shutdown hook panic recovery#473codefromthecrypt wants to merge 2 commits into
codefromthecrypt wants to merge 2 commits into
Conversation
mathetake
approved these changes
Jul 18, 2025
This implements ctrl+c twice functionality where the first interrupt starts graceful shutdown and any subsequent interrupt forces immediate exit via os.Exit(1). The implementation handles normal shutdown scenarios gracefully. The known limitation on Darwin (envoy orphaning on SIGKILL) is documented and tested. Fixes #456 Signed-off-by: Adrian Cole <adrian@tetrate.io>
codefromthecrypt
force-pushed
the
ctrl-c-twice-fix
branch
from
8778de0 to
8b76ba8
Compare
Collaborator
Author
|
incomplete.. there's a flake |
Collaborator
Author
|
"when in a hole, stop digging" I'm closing this out to delete the concept of shutdown hooks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements ctrl+c twice functionality where the first interrupt starts graceful shutdown and any subsequent interrupt forces immediate exit via os.Exit(1).
The implementation handles normal shutdown scenarios gracefully. The known limitation on Darwin (envoy orphaning on SIGKILL) is documented and tested.
Fixes #456