[sql] syntax highlighting error

[aeschli]

From @DenSmoke on December 24, 2015 11:10

Problems with ' '

Copied from original issue: microsoft/vscode#1634

[aeschli]

@DenSmoke Denis, can you paste problematic snippet? It looks like an issue with Unicode characters which I see as well, but I get different errors. Thanks!

[aeschli]

From @DenSmoke on January 8, 2016 16:8

@aeschli
5.1.1
INSERT INTO
ТОВАРЫ(ИЗГОТОВИТЕЛЬ,ШИФР,НАИМЕНОВАНИЕ,ЦЕНА,ЛИМИТ)
VALUES
('ААА','А01','Какой то товар',100,20)
SELECT * FROM ТОВАРЫ
5.2.1
INSERT INTO
СТРОКИ_ПРАЙСА (КОД_ТОВАРА,НАЗВАНИЕ_ТОВАРА,ЦЕНА_ТОВАРА)
SELECT
ИЗГОТОВИТЕЛЬ||ШИФР,НАИМЕНОВАНИЕ,ЦЕНА
FROM
ТОВАРЫ
WHERE
ИЗГОТОВИТЕЛЬ<>'ЗОМ'

[aeschli]

VSCode uses the latest grammar from https://github.com/textmate/sql.tmbundle/blob/master/Syntaxes/SQL.plist

[kasecato]

@aeschli delete lines: 570-590, it will work fine.
master...k--kato:patch-1

[aeschli]

The bug was in VS Code's Oniguruma regex library. Closing.

[aeschli]

The bug was in VS Code's Oniguruma regex library. Fixed in the January build.

[gontadu]

@aeschli So should grammar changes be made just once either on Textmate/VSCode's side or on both?

e.g. microsoft/vscode#8174

[aeschli]

@gontadu Always in both. Preferably in the original repository first.
But this issue was a bug in our regex library.

[gontadu]

Thanks @aeschli How often does VSCode's downstream sql grammar sync with the upstream textmate bundle?