Skip to content

Conversation

@mdwRepository
Copy link

This pull request introduces Pylint as proposed in #34. The following changes are included:

  • added pylint requirements
  • created an initial .pylintrc file to configure linting rules as needed, e.g., ignoring files, folders, or specific rules.
  • refactored scripts console.py, example.py, example_gets.py, setup.py, and solr_example.py to comply with Pylint standards except for module docstrings.
  • refactored code in models.py to remove unnecessary use of arguments when calling super for the parent class, removed commas after values to avoid turning it into a tuple, and used literals instead of calling list/set/dict
  • refactored code in client.py to import models explicitly instead of a wildcard, used lazy % formatting in logging functions, and fixed some C0301: Line too long issues

Other pylint issues were intentionally omitted as they may require further discussion with the project team.

@pnbecker
Copy link
Member

pnbecker commented Dec 4, 2024

I‘m very happy to see this pull-request. Thank you for sorting out the technical issues to create it!

@kshepherd kshepherd self-requested a review December 4, 2024 17:03
Copy link
Collaborator

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 thanks @mdwRepository - I will add some usage notes in teh next readme, too

@kshepherd kshepherd merged commit 6dd06f6 into the-library-code:main Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants