LINK_TYPE_DSA_GSW1XX: add EDSA protocol for GSW1xx family. #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For use of MaxLinear GSW1xx DSA driver in Linux.
infrastation
reviewed
Dec 8, 2025
| ;; | ||
| gsw1xx-switch-tag) | ||
| title='GSW1XX switch tag | ' | ||
| ;; |
Member
There was a problem hiding this comment.
This change has no purpose in this version.
infrastation
reviewed
Dec 8, 2025
|
|
||
| <tr> | ||
| <td class="symbol">LINKTYPE_DSA_TAG_GSW1XX</td> | ||
| <td class="number">302</td> |
Member
There was a problem hiding this comment.
This should be 303 and should appear after LINKTYPE_EDK2_MM below because the table is sorted by numeric ID.
Member
There was a problem hiding this comment.
Correction: it should be 304, let me add the latest assignment to the table first.
Member
There was a problem hiding this comment.
Done. Please use the latest master branch and make it 304.
infrastation
reviewed
Dec 8, 2025
| </ul> | ||
| Format of (Ethertyped) Ingress tagged frames: | ||
| <pre> | ||
| +0 +----+----+----+----+----+----+----+----+ |
Member
There was a problem hiding this comment.
Please note indentation is off in the packet diagrams.
infrastation
reviewed
Dec 8, 2025
| +6 +----+----+----+----+----+----+----+----+ +- | ||
| | Prog. DSA Ether Type [15:8] | | (8-byte) Special Tag | ||
| +1 +----+----+----+----+----+----+----+----+ | Contains a programmable Ether type. | ||
| | Prog. DSA Ether Type [7:0] | | + |
Member
There was a problem hiding this comment.
Special Tag Content ends in the middle of programmable EtherType in this packet diagram, should be exactly 6 bytes after EtherType according to the data sheet.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For use of MaxLinear GSW1xx DSA driver in Linux.
v2: Renamed to Special Tag, merged to one page for Special-Tag.