Skip to content

fix blocking all scrolling when RemoveScroll is used within ShadowRoot#98

Merged
theKashey merged 3 commits intotheKashey:masterfrom
csorfab:shadow-root-fix-alternative
Oct 3, 2023
Merged

fix blocking all scrolling when RemoveScroll is used within ShadowRoot#98
theKashey merged 3 commits intotheKashey:masterfrom
csorfab:shadow-root-fix-alternative

Conversation

@csorfab
Copy link
Copy Markdown
Contributor

@csorfab csorfab commented Sep 23, 2023

This PR fixes issue #45 as per the discussion in #97

@csorfab csorfab mentioned this pull request Sep 23, 2023
Closed
@theKashey
Copy link
Copy Markdown
Owner

theKashey commented Sep 25, 2023

Looks brilliant 👍 . Give me some time to test it

theKashey
theKashey reviewed Sep 27, 2023
View reviewed changes
Comment thread src/handleScroll.ts
let availableScrollTop = 0;

do {
if (target instanceof ShadowRoot) {
Copy link
Copy Markdown
Owner

@theKashey theKashey Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"when" this happens?
Description of commit is about "mobile", but how it's related?

Copy link
Copy Markdown
Contributor Author

@csorfab csorfab Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the event comes from within a ShadowRoot, then the target's .parentNode() up the tree will eventually be the ShadowRoot, and we need to step out of it with .host (because a ShadowRoot's parentNode is null). I'm not exactly sure why this fixes it, but touch scrolling doesn't work without this in my use case. I already wanted to do this regardless, because it seems like the "right" thing to do with regards to ShadowDOM, but it also ended up fixing the issue on mobile.

@theKashey theKashey merged commit 0fe6cf9 into theKashey:master Oct 3, 2023
@theKashey
Copy link
Copy Markdown
Owner

theKashey commented Oct 9, 2023

Sorry for delay. Found a few issues with math and it took some time to find the root cause.
The problem was not with your change, but with floating point calculations if page is a little scaled, and my page was a little scaled 😅

@theKashey
Copy link
Copy Markdown
Owner

theKashey commented Oct 10, 2023

Released as a part of v 2.5.7

@glenntws glenntws mentioned this pull request Oct 27, 2023
Closed
@NOUIY NOUIY mentioned this pull request May 25, 2024
Open
@NOUIY NOUIY mentioned this pull request Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theKashey theKashey theKashey approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@csorfab @theKashey