Add multi user support and do code cleanup#1
Open
sujairamprasathc wants to merge 34 commits intothebinarybot:mainfrom
Open
Add multi user support and do code cleanup#1sujairamprasathc wants to merge 34 commits intothebinarybot:mainfrom
sujairamprasathc wants to merge 34 commits intothebinarybot:mainfrom
Conversation
Collaborator
sujairamprasathc
commented
Sep 22, 2021
sujairamprasathc
commented
- Complete the project as originally proposed by adding multi user support
- Perform major refactors and clean up hacky code to conform to best practices
- Add app logo
* Fix app always loading post-login page (parse isUserLoggedIn to boolean) * Change homepage in package.json * Remove unused NavBarToggler import in NavBar.js * Replace data loading code in App.js with componentDidMount
* Move course details to AttendanceCard state * Re-render card on button clicks with updated data from API server * Render cards only if data is available, do not show loading
* Fix broken variable names * Add react-router for client side routing * Refactor code and separate components from views * Add logging * Add BASEPATH to NavBar links
Change code to conform to Google's style guide for JavaScript
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.