feat: reasoning traces (System 2 Memory) — ADR-003

[thebtf]

Summary

Implements Reasoning Traces — a second memory layer that captures HOW the agent reasons, not just WHAT it decided. Based on ADR-003 and Cipher competitive analysis.

Phase 1: Data Model

• Migration 065: reasoning_traces table with steps JSONB, quality_score, task_context
• GORM model + ReasoningTraceStore (Create/GetBySession/SearchByProject)

Phase 2: Reasoning Detection + Extraction

• DetectReasoning() — detects multi-step reasoning patterns (3+ indicators in 200+ chars)
• LLM prompts for trace extraction and quality evaluation
• Async extraction in ProcessObservation (non-blocking, quality threshold ≥ 0.5)

Phase 3: MCP Tool Integration

• recall(action="reasoning") — searches and formats reasoning traces
• Added to recall action enum, wired into service

Not in this PR (Phase 4)

• Context injection of reasoning traces on session-start

Test plan

• go build ./... passes
• go vet ./... passes
• Migration creates reasoning_traces table
• recall(action="reasoning", project="engram") returns empty (no traces yet)
• Multi-step reasoning in tool events triggers extraction (after LLM is available)

Summary by CodeRabbit

Примечания к выпуску

• Новые возможности
  • Автоматическое извлечение и сохранение цепочек рассуждений из сессий.
  • Поиск сохранённых следов рассуждений по проекту с фильтрацией по оценке качества.
  • Новое действие "reasoning" в инструменте отзыва для просмотра найденных следов.
  • Возможность получить недавние следы по сессии с ограничением числа результатов.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2faa4c44-b4d9-459a-b4e6-03db50483191

📥 Commits

Reviewing files that changed from the base of the PR and between c5add3a and 1d093ec.

📒 Files selected for processing (9)

• internal/db/gorm/migrations.go
• internal/db/gorm/models.go
• internal/db/gorm/reasoning_store.go
• internal/mcp/server.go
• internal/mcp/tools_recall.go
• internal/worker/sdk/processor.go
• internal/worker/sdk/prompts.go
• internal/worker/sdk/reasoning_detector.go
• internal/worker/service.go

---

Walkthrough

Добавлена поддержка извлечения, оценки и хранения цепочек рассуждений: новая таблица БД и модель GORM, хранилище для reasoning traces, асинхронная логика извлечения и оценки в SDK-процессоре с вызовами LLM, и поисковый recall-экшен в MCP-сервере для отображения сохранённых цепочек.

Changes

Cohort / File(s)	Summary
Миграция и модель internal/db/gorm/migrations.go, internal/db/gorm/models.go	Добавлена миграция 065_reasoning_traces и GORM-модель ReasoningTrace с полями: sdk_session_id, project, steps (JSONB), quality_score, task_context, created_at, created_at_epoch и индексами; хук BeforeCreate заполняет epoch/time.
Хранилище GORM internal/db/gorm/reasoning_store.go	Новый ReasoningTraceStore с методами Create, GetBySession, SearchByProject и GetDB, логика лимитов и фильтрации по quality_score.
Процессор SDK internal/worker/sdk/processor.go, internal/worker/sdk/prompts.go, internal/worker/sdk/reasoning_detector.go	Добавлено поле reasoningStore, метод установки, детектор рассуждений DetectReasoning, два промпта для извлечения и оценки, асинхронная функция extractAndStoreReasoning с двумя LLM-вызовами, парсингом, фильтрацией по порогу качества и сохранением.
Инициализация сервиса internal/worker/service.go	Создание и подключение ReasoningTraceStore при initialize/reinitialize и привязка к процессору и MCP-серверу.
MCP — recall и сервер internal/mcp/server.go, internal/mcp/tools_recall.go	Добавлено поле reasoningStore в Server, метод SetReasoningStore, новый recall-экшен reasoning и рендеринг найденных трейсoв (парсинг steps JSON и форматирование результатов).

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Processor as SDK Processor
    participant Detector as Reasoning Detector
    participant LLM
    participant DB as ReasoningTraceStore

    Client->>Processor: ProcessObservation(response)
    Processor->>Detector: DetectReasoning(response)
    Detector-->>Processor: bool (detected?)

    alt Detected && reasoningStore configured && storedCount>0
        Processor->>Processor: spawn goroutine extractAndStoreReasoning
        Processor->>LLM: Extract chain (reasoningExtractionPrompt + response)
        LLM-->>Processor: JSON trace
        Processor->>LLM: Score trace (reasoningQualityPrompt + trace)
        LLM-->>Processor: quality (0..1)
        alt quality >= 0.5
            Processor->>DB: Create(ReasoningTrace)
            DB-->>Processor: id / error
        end
    end

Loading

sequenceDiagram
    participant User
    participant MCP as MCP Server
    participant Store as ReasoningTraceStore
    participant DB

    User->>MCP: recall(action="reasoning", project, limit)
    MCP->>Store: SearchByProject(project, limit)
    Store->>DB: SELECT .. WHERE project=? AND quality_score>=0.5 ORDER BY ...
    DB-->>Store: []ReasoningTrace
    Store-->>MCP: traces
    MCP->>MCP: unmarshal steps JSON, format output
    MCP-->>User: formatted reasoning chains

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 минут

Possibly related PRs

• feat: MCP tool API consolidation — 61 tools → 7 primary #113 — изменения в обработке recall и маршрутизации MCP, пересекаются с internal/mcp/tools_recall.go и server.go.
• feat: extraction quality v2 — category prompts + behavioral rules #43 — модификации логики обработки наблюдений в internal/worker/sdk/processor.go, смежные изменения по извлечению/обработке ответов LLM.
• feat: collection MCP tools and instinct import #2 — обновления инициализации/подключения хранилищ в MCP/worker, схожая схема wiring SetReasoningStore/новых стор.

Suggested labels

ai-review:passed

Poem

🐇 Я — кролик, что мысли хранит,
Поймал след рассуждений в сеть,
Шаги, контекст и балл — как свет,
В базе пусть цепочка живёт,
Recall её вернёт в ответ. 🥕

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/reasoning-traces

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[thebtf]

@coderabbitai review

[thebtf]

@gemini-code-assist review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[gemini-code-assist]

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

[thebtf]

@codex review