fix(ui): multi-line comment textarea (#25)#137
Conversation
- POST /api/import/feedback: accepts feedback_*.md content, processes through server-side LLM (FeedbackImportSystemPrompt), stores as type=guidance observation with semantic dedup (0.90 threshold) - CLI engram-import: sends files to server via HTTP instead of calling LLM directly (LLM only accessible from server/LM Studio) - Removes direct LLM dependency from CLI binary
Closes #25: the "Add Comment (as operator)" field was a single-line <input> that couldn't hold multi-line content like stack traces or code blocks. Now uses a <textarea> with 4 default rows, resizable up to 400px. Submit shortcut changed from Enter to Ctrl+Enter (Cmd+Enter on macOS) so Enter inserts a newline.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 46 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (17)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request implements project-scoped filtering for observations and refactors session outcome handling to support both Claude session IDs and numeric database IDs. It introduces session auto-creation during outcome updates and ensures canonical session IDs are used across various MCP and worker handlers. The frontend was updated to provide a better commenting experience with a textarea, and the plugin's stop hook was made more resilient to missing database identifiers. Feedback suggests ensuring consistent RFC3339 timestamp formatting in the session store and applying URL encoding to session IDs in the plugin's API calls.
| Updates(map[string]interface{}{ | ||
| "outcome": outcome, | ||
| "outcome_reason": reason, | ||
| "outcome_recorded_at": time.Now(), |
There was a problem hiding this comment.
The outcome_recorded_at field should be explicitly formatted as an RFC3339 string for consistency with other timestamp fields in this store (like StartedAt at line 287). Passing a time.Time object to Updates for a string column relies on the database driver's default string representation, which may not match the expected format.
| "outcome_recorded_at": time.Now(), | |
| "outcome_recorded_at": time.Now().Format(time.RFC3339), |
|
|
||
| await lib.requestPost( | ||
| `/api/sessions/${sessionID}/outcome`, | ||
| `/api/sessions/${claudeSessionID}/outcome`, |
There was a problem hiding this comment.
The claudeSessionID should be URL-encoded when used in the path to prevent issues if the ID contains special characters. Other similar calls in this file (e.g., lines 349, 386) already use encodeURIComponent.
| `/api/sessions/${claudeSessionID}/outcome`, | |
| '/api/sessions/' + encodeURIComponent(claudeSessionID) + '/outcome', |
1 participant
Summary
<input>with multi-line<textarea>in issue detail comment formChanges
ui/src/views/IssueDetailView.vue:<input>→<textarea rows="4">withresize-y, min 80px / max 400pxEnter→Ctrl+Enter/Cmd+Enter(Enter now inserts newline)Test plan