chore: remove dead tree-sitter chunkers and dependency (FR-10)#14
Conversation
Delete internal/chunking/typescript/ and internal/chunking/python/ which were never registered in createChunkManager() and caused Windows build failures due to broken CGo imports in go-tree-sitter.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughУдалены AST-ориентированные чанкеры для Python и TypeScript (включая тесты) и зависимость от github.com/smacker/go-tree-sitter; добавлена прямая зависимость github.com/google/uuid v1.6.0 в go.mod. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Стихотворение
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on cleaning up the codebase by removing dead code related to tree-sitter chunkers for Python and TypeScript. It also addresses a dependency issue that was causing build failures on Windows. The changes improve the overall maintainability and stability of the project. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request does a great job of removing dead code and simplifying dependencies by deleting the unused Python and TypeScript tree-sitter chunkers. The changes are clean and address the stated goal of fixing the CGo build issue on Windows. I've added a couple of minor suggestions to remove some now-orphaned constants for a more complete cleanup.
|
@codex review |
…Script constants Python and TypeScript chunkers were removed in this PR. Their corresponding Language constants in types.go are now dead code. Remove them along with the associated test assertions.
Backend: - Migration 075: add type column (TEXT, default 'task') to issues table - Issue model: Type field with validation (bug/feature/improvement/task) - Store: CreateIssue validates type, UpdateIssueFields accepts type, ListIssuesEx filters by type - MCP tool: type param in issues(action="create") - REST: type in POST/PATCH body, GET query param Dashboard: - "New Issue" button + creation modal (title, body, type, priority, target_project) - Type filter buttons (All/Bug/Feature/Improvement/Task) - Type badge in issue list (colored: red/blue/green/gray) - Type badge + edit in issue detail view Hooks: - formatIssuesBlock shows [TYPE] tag in session injection Plugin v3.7.8. Closes #31, #14.
* feat(issues): add type field (bug/feature/improvement/task) [T001-T008] * feat(issues): add type field + operator create from dashboard (#31, #14) Backend: - Migration 075: add type column (TEXT, default 'task') to issues table - Issue model: Type field with validation (bug/feature/improvement/task) - Store: CreateIssue validates type, UpdateIssueFields accepts type, ListIssuesEx filters by type - MCP tool: type param in issues(action="create") - REST: type in POST/PATCH body, GET query param Dashboard: - "New Issue" button + creation modal (title, body, type, priority, target_project) - Type filter buttons (All/Bug/Feature/Improvement/Task) - Type badge in issue list (colored: red/blue/green/gray) - Type badge + edit in issue detail view Hooks: - formatIssuesBlock shows [TYPE] tag in session injection Plugin v3.7.8. Closes #31, #14. * fix(issues): address PR #145 review findings - migrations.go: add DB-level CHECK constraint issues_type_check for type IN ('bug','feature','improvement','task') with proper rollback - models.go: add not null to GORM tag for Type field to match migration - handlers_issues.go: normalize type param with TrimSpace+ToLower in list, create, and update handlers - api.ts: refactor createIssue to use postJson helper (removes duplicated timeout/abort/retry logic); require non-empty target_project and validate eagerly before HTTP call - IssuesView.vue: pass target_project as string (not undefined) since createIssue now validates it directly --------- Co-authored-by: Kirill Turanskiy <thebtf@users.noreply.github.com>
1 participant
Summary
internal/chunking/typescript/andinternal/chunking/python/(dead code — never registered increateChunkManager())github.com/smacker/go-tree-sitterpseudo-version dependency from go.modTest plan
go build ./cmd/worker/compiles on Windows without CGo errorsgo mod tidyshows no pseudo-versioned dependenciesSummary by CodeRabbit
Заметки о выпуске
Chores
Refactor
Tests