Skip to content

chore(deps): bump mcp-mux/muxcore v0.19.0 → v0.19.7 (drop-in)#182

Merged
thebtf merged 1 commit into
mainfrom
chore/bump-muxcore-v0.19.7
Apr 18, 2026
Merged

chore(deps): bump mcp-mux/muxcore v0.19.0 → v0.19.7 (drop-in)#182
thebtf merged 1 commit into
mainfrom
chore/bump-muxcore-v0.19.7

Conversation

@thebtf
Copy link
Copy Markdown
Owner

@thebtf thebtf commented Apr 18, 2026

Closes engram issue #87.

Drop-in dependency bump — zero consumer code changes. See commit message for release-note details (3 releases chain: v0.19.5/6/7).

Verified

  • go build ./... — clean
  • go vet ./... — clean
  • go test -short -count=1 ./... — all unit tests green (integration tests skip without DATABASE_DSN)

Why MEDIUM priority

Engram uses the legacy Handler path, not SessionHandler. The two primary production bugs in the chain don't trigger here. BUT the v0.19.7 fix for upstream.Process.ReadLine normalising os.ErrClosed -> io.EOF does help — engram subprocesses that exit quickly get a cleaner error path. Plus forward-compat for the daemon/SessionHandler migration (2026-04-12 architecture decision).

No impact on US3

This PR is off main and independent of PR #181 (US3 observations split). No scope overlap, no file conflicts.

Summary by CodeRabbit

  • Chores
    • Обновлены внутренние зависимости проекта для повышения стабильности и совместимости.

Three mcp-mux releases landed since v0.19.3 (prior engram baseline
was actually v0.19.0 per go.mod). Drop-in for engram — zero consumer
code changes required.

Engram uses the legacy Handler path (not SessionHandler) and does not
host the mcp-mux daemon, so the two primary production bugs motivating
the chain (keepalive spec violation + zombie-listener) are not directly
triggerable. However the release contains one correctness fix that
benefits engram even on the legacy path:

- upstream.Process.ReadLine now normalises os.ErrClosed -> io.EOF.
  exec.Cmd.StdoutPipe closes the pipe after cmd.Wait returns, and Start
  runs Wait in a background goroutine concurrent with external ReadLine.
  Fast-exiting upstreams previously surfaced 'read |0: file already
  closed' which is semantically EOF. Engram subprocesses that exit
  quickly (tests, short health probes) now see the cleaner error path.

Plus forward-compat value — once engram moves to the daemon/SessionHandler
path per the 2026-04-12 architecture decision, fixes from v0.19.5/6/7
are already on board.

Release notes:
- https://github.com/thebtf/mcp-mux/releases/tag/muxcore/v0.19.5
- https://github.com/thebtf/mcp-mux/releases/tag/muxcore/v0.19.6
- https://github.com/thebtf/mcp-mux/releases/tag/muxcore/v0.19.7

Verified:
- go build ./... — clean
- go vet ./... — clean
- go test -short -count=1 ./... — all unit tests pass (integration
  suites skip cleanly without DATABASE_DSN)

Closes engram issue #87.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6546f6e2-c02d-424a-beef-bd89af33ca21

📥 Commits

Reviewing files that changed from the base of the PR and between 83bbc62 and d27b2f0.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod

Обзор

Обновлена версия зависимости Go-модуля github.com/thebtf/mcp-mux/muxcore с версии v0.19.0 на v0.19.7 в файле go.mod. Других изменений в требованиях модуля или публичных API не производилось.

Изменения

Когорта / Файл(ы) Описание
Обновление зависимости
go.mod
Обновлена версия github.com/thebtf/mcp-mux/muxcore с v0.19.0 на v0.19.7

Возможно связанные PR

Предлагаемые метки

ai-review:active

Оценка трудозатратности кода

🎯 1 (Тривиально) | ⏱️ ~2 минуты

Стихотворение

🐰 Версия прыгнула с семи на семь,
Мухомукс теперь поёт с успехом!
Кролик смотрит: "Красота — вот это да!"
Обновленье малое, да многофункциональное оно,
И go.mod поёт об этом с радостью!

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed Заголовок PR полностью соответствует основному изменению: обновление зависимости mcp-mux/muxcore с v0.19.0 на v0.19.7, с указанием того, что это drop-in изменение.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-muxcore-v0.19.7

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the github.com/thebtf/mcp-mux/muxcore dependency from version v0.19.0 to v0.19.7 in go.mod and go.sum. I have no feedback to provide.

@thebtf thebtf merged commit f5fee00 into main Apr 18, 2026
8 checks passed
@thebtf thebtf deleted the chore/bump-muxcore-v0.19.7 branch May 7, 2026 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant