feat(us8b): drop learning + analytics UI views (PR-v5-8b)#188
Merged
Conversation
Part of engram v5.0.0 US8 BREAKING cleanup — UI portion. - Delete ui/src/views/LearningView.vue - Delete ui/src/views/AnalyticsView.vue - Remove router routes /learning, /analytics - Remove sidebar nav items learning, analytics This PR is UI-only. The Go-side learning/scoring subsystems are dropped in companion PR US8-C (Go core) and US8-A (config env vars). Split per user guidance to reduce per-PR scope. REVERSIBLE.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
ОбзорУдалены две навигационные записи (аналитика и обучение) из боковой панели и определения маршрутов, а также полностью удалены связанные компоненты представлений AnalyticsView.vue и LearningView.vue, что исключает эти функции из приложения. Изменения
Оценка сложности проверки кода🎯 1 (Тривиально) | ⏱️ ~3 минуты Стихотворение
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Owner
Author
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the 'Analytics' and 'Learning' features from the application. The changes include deleting the navigation items from the sidebar, removing the associated routes from the router, and deleting the AnalyticsView.vue and LearningView.vue view components. I have no feedback to provide.
thebtf
added a commit
that referenced
this pull request
Apr 18, 2026
Part of engram v5.0.0 US10 cleanup. Follows US6 (GraphView drop), US8-B (LearningView + AnalyticsView drop). - Delete `ui/src/views/PatternsView.vue` (21KB — references dropped patterns API from US5) - Delete `ui/src/views/MonitorView.vue` (15KB — observability view, replaced by server logs endpoint) - Delete `ui/src/views/SystemView.vue` (19KB — scoring stats, dropped in US8-C) - Remove router routes `/patterns`, `/monitor`, `/logs` (redirect), `/system` - Remove sidebar nav items: patterns, monitor, system Stats: 5 files changed, 1525 deletions. UI build (`npm run build`) green with surviving views. Companion PRs: - US6 (#187) ✅ — GraphView - US8-B (#188) ✅ — LearningView + AnalyticsView Stale API helpers in `ui/src/utils/api.ts` (patterns/monitor) retained — unused exports; will be cleaned in a dedicated UI cleanup PR. REVERSIBLE. Per C7 (CodeRabbit only).
thebtf
added a commit
that referenced
this pull request
Apr 19, 2026
…0) (#190) Part of engram v5.0.0 US10 cleanup. Follows US6 (GraphView drop), US8-B (LearningView + AnalyticsView drop). - Delete `ui/src/views/PatternsView.vue` (21KB — references dropped patterns API from US5) - Delete `ui/src/views/MonitorView.vue` (15KB — observability view, replaced by server logs endpoint) - Delete `ui/src/views/SystemView.vue` (19KB — scoring stats, dropped in US8-C) - Remove router routes `/patterns`, `/monitor`, `/logs` (redirect), `/system` - Remove sidebar nav items: patterns, monitor, system Stats: 5 files changed, 1525 deletions. UI build (`npm run build`) green with surviving views. Companion PRs: - US6 (#187) ✅ — GraphView - US8-B (#188) ✅ — LearningView + AnalyticsView Stale API helpers in `ui/src/utils/api.ts` (patterns/monitor) retained — unused exports; will be cleaned in a dedicated UI cleanup PR. REVERSIBLE. Per C7 (CodeRabbit only). Co-authored-by: Kirill Turanskiy <thebtf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
US8-B: Drop Learning + Analytics UI Views (BREAKING, UI-only)
Split from US8 per user guidance (smaller PRs, clearer review).
Scope
ui/src/views/LearningView.vue,ui/src/views/AnalyticsView.vue/learning,/analyticsfromui/src/router/index.tsui/src/components/layout/AppSidebar.vueStats
Companion PRs (not yet opened)
Conventions
Reversibility
REVERSIBLE (code).
🤖 Generated with Claude Code
Summary by CodeRabbit