fix(ui): inset sidebar with rounded content panel#211
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
ОбзорИзменения настраивают стиль боковой панели приложения путём добавления класса Изменения
Оценка затрат на проверку кода🎯 1 (Trivial) | ⏱️ ~3 минуты Поэма
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the sidebar styling by adjusting the background color variable and applying the 'inset' variant to the sidebar component. A review comment identifies that the background class added to the SidebarProvider is redundant because the inset variant already handles this styling, suggesting its removal for a cleaner implementation.
|
|
||
| <!-- Authenticated layout --> | ||
| <SidebarProvider v-else> | ||
| <SidebarProvider v-else class="bg-sidebar"> |
There was a problem hiding this comment.
The class="bg-sidebar" is redundant here. The SidebarProvider component already includes a has-[[data-variant=inset]]:bg-sidebar utility (see SidebarProvider.vue line 75) that automatically applies the sidebar background color when the variant="inset" is used on the child sidebar. Removing this manual class keeps the template cleaner and avoids potential styling conflicts if the sidebar variant is changed in the future.
<SidebarProvider v-else>
Adds rounded corners to the content panel, creating visual separation from the sidebar (like the reference screenshot).
Changes
AppSidebar.vue:variant="inset"— activates shadcn/ui inset mode (rounded corners, removes sidebar border)App.vue:class="bg-sidebar"on SidebarProvider — sidebar color shows behind rounded cornersmain.css: light mode--sidebar-backgrounddifferentiated from--background(94% vs 98%) so the effect is visible in both themesSummary by CodeRabbit
Примечания к выпуску