Skip to content

fix(ui): inset sidebar with rounded content panel#211

Merged
thebtf merged 1 commit into
mainfrom
fix/sidebar-inset
Apr 26, 2026
Merged

fix(ui): inset sidebar with rounded content panel#211
thebtf merged 1 commit into
mainfrom
fix/sidebar-inset

Conversation

@thebtf
Copy link
Copy Markdown
Owner

@thebtf thebtf commented Apr 26, 2026

Adds rounded corners to the content panel, creating visual separation from the sidebar (like the reference screenshot).

Changes

  • AppSidebar.vue: variant="inset" — activates shadcn/ui inset mode (rounded corners, removes sidebar border)
  • App.vue: class="bg-sidebar" on SidebarProvider — sidebar color shows behind rounded corners
  • main.css: light mode --sidebar-background differentiated from --background (94% vs 98%) so the effect is visible in both themes

Summary by CodeRabbit

Примечания к выпуску

  • Style
    • Обновлена визуальная стилизация боковой панели навигации с улучшенным отображением фона и внешним видом.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2d8b188c-25c5-456d-94f4-839058fd5575

📥 Commits

Reviewing files that changed from the base of the PR and between e683280 and d0f709f.

📒 Files selected for processing (3)
  • ui/src/App.vue
  • ui/src/assets/main.css
  • ui/src/components/layout/AppSidebar.vue

Обзор

Изменения настраивают стиль боковой панели приложения путём добавления класса bg-sidebar к компоненту SidebarProvider, внедрения варианта inset в компонент Sidebar и снижения яркости фонового цвета CSS переменной --sidebar-background с 98% до 94% для светлой темы.

Изменения

Когорта / Файл(ы) Описание
Стилизация и конфигурация боковой панели
ui/src/App.vue, ui/src/assets/main.css, ui/src/components/layout/AppSidebar.vue
Добавлены стилевые пропсы к компоненту SidebarProvider (класс bg-sidebar), внедрена конфигурация variant="inset" для компонента Sidebar, и отрегулирован цвет фона боковой панели в CSS переменной --sidebar-background (снижение яркости с 98% до 94%).

Оценка затрат на проверку кода

🎯 1 (Trivial) | ⏱️ ~3 минуты

Поэма

🐰 Тройка перемен, легка́я как пух,
Боковушка светлится, светится вмиг,
От 98 процентов спешу я спешат́ь,
На 94 тень я спешу нанеса́ть,
Вот inset взлета́ет, как ушки в любви́! 💕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding an inset sidebar variant with rounded content panel styling, which aligns with the PR objectives and file modifications across App.vue, AppSidebar.vue, and main.css.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sidebar-inset

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the sidebar styling by adjusting the background color variable and applying the 'inset' variant to the sidebar component. A review comment identifies that the background class added to the SidebarProvider is redundant because the inset variant already handles this styling, suggesting its removal for a cleaner implementation.

Comment thread ui/src/App.vue

<!-- Authenticated layout -->
<SidebarProvider v-else>
<SidebarProvider v-else class="bg-sidebar">
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The class="bg-sidebar" is redundant here. The SidebarProvider component already includes a has-[[data-variant=inset]]:bg-sidebar utility (see SidebarProvider.vue line 75) that automatically applies the sidebar background color when the variant="inset" is used on the child sidebar. Removing this manual class keeps the template cleaner and avoids potential styling conflicts if the sidebar variant is changed in the future.

    <SidebarProvider v-else>

@thebtf thebtf merged commit 7190160 into main Apr 26, 2026
8 checks passed
@thebtf thebtf deleted the fix/sidebar-inset branch April 26, 2026 22:59
thebtf added a commit that referenced this pull request May 7, 2026
5 fixes since v6.0.0:
- clipboard copy fix in dialog + CLI --help/--version flags (#209)
- gitleaks-friendly placeholder in setup.md example (e229fbf)
- bump muxcore v0.21.6 -> v0.21.19 (#210)
- inset sidebar with rounded content panel (#211)
- brand assets + sync infrastructure (#212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant