Use ComposerFinder's useAutoloading method#667
Use ComposerFinder's useAutoloading method#667oojacoboo merged 5 commits intothecodingmachine:masterfrom
Conversation
|
@oprypkhantc Can't you just set your own customized $finder = (new ComposerFinder)->useAutoloading(false);
$schemaFactory->setFinder($finder); |
|
@oojacoboo This PR is mostly for backwards compatibility. Let me explain: Up until now, graphqlite used Now the author of the library pushed a commit to With this PR, I've upgraded to We'll still need this PR to fix the tests and add a |
|
@oprypkhantc yep - got it. I think we remove this option in GraphQLite and update documentation on how to disable using something like the example code I provided above. |
|
@oojacoboo Done :) Added a small section in the docs about autoloading. Also I'm not sure why docs generation fails on CI - it builds locally no problem 👀 |
|
Merged. Sometimes the test runners just crap out and need to be re-run. |
Closes #659
This implementation is much simpler: now that we use kcs/class-finder and that it has autoloading enabled by default, the only thing left to do is provide an option to disable it if you need the "legacy" behaviour for whatever reason.
I've tested the new autoloading flow in our project and it's behaving exactly as expected.