[Error handling] Remove category from exceptions#685
Merged
oojacoboo merged 3 commits intothecodingmachine:masterfrom May 9, 2024
Merged
[Error handling] Remove category from exceptions#685oojacoboo merged 3 commits intothecodingmachine:masterfrom
oojacoboo merged 3 commits intothecodingmachine:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
============================================
- Coverage 95.72% 95.43% -0.30%
- Complexity 1773 1805 +32
============================================
Files 154 171 +17
Lines 4586 4775 +189
============================================
+ Hits 4390 4557 +167
- Misses 196 218 +22 ☔ View full report in Codecov by Sentry. |
oojacoboo
approved these changes
May 9, 2024
Collaborator
|
@cvergne thanks for this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #683, category support has already been removed from graphQL error responses with graphqlite because of graphql-php update to v15 ( see upgrade guide v14 -> v15 ), which means
categoryis already missing fromextensionsin responses.The purpose of this PR is to remove the category argument from Exceptions.
Caution
BC Break
The
categoryargument has been removed fromGraphQLException, which means any existing instance of a GraphQLException passing category and/or extensions will trigger an error.BEFORE
AFTER
Note
If you want to keep
category, you'll have two options :GraphQLExceptionclass and using your ownerrorFormattermethodextensionsFixes #683