Skip to content

Deprecating a bunch of useless functions.#17

Merged
moufmouf merged 7 commits intothecodingmachine:1.0from
moufmouf:deprecate_functions
Oct 8, 2015
Merged

Deprecating a bunch of useless functions.#17
moufmouf merged 7 commits intothecodingmachine:1.0from
moufmouf:deprecate_functions

Conversation

@moufmouf
Copy link
Copy Markdown
Member

@moufmouf moufmouf commented Oct 7, 2015

See #15

@stof
Copy link
Copy Markdown
Contributor

stof commented Oct 7, 2015

does Mouf support reporting deprecations using the convention introduced in symfony (i.e. @trigger_error('...', E_USER_DEPRECATED), so that error handlers not supporting the convention don't convert the deprecation warning to an exception thus breaking things) ?
If no, you should probably provide an integration of the Twig_Util_DeprecationCollector, to find usage of deprecated Twig features

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given that the translate function would still require at least 1 argument, you would make this change directly in translate and use the same implementation for the function and the filter

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice! 👍

@stof
Copy link
Copy Markdown
Contributor

stof commented Oct 7, 2015

should the t function be deprecated in favor of the t filter ?

@moufmouf
Copy link
Copy Markdown
Member Author

moufmouf commented Oct 7, 2015

should the t function be deprecated in favor of the t filter ?

True.

@moufmouf
Copy link
Copy Markdown
Member Author

moufmouf commented Oct 7, 2015

If no, you should probably provide an integration of the Twig_Util_DeprecationCollector, to find usage of deprecated Twig features

I'll open a separate issue for this.

moufmouf added a commit that referenced this pull request Oct 8, 2015
Deprecating a bunch of useless functions.
@moufmouf moufmouf merged commit 749f1bc into thecodingmachine:1.0 Oct 8, 2015
@moufmouf moufmouf deleted the deprecate_functions branch October 8, 2015 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants