Fix "FROM" with the specified database#80
Open
rodion-k wants to merge 10 commits intothecodingmachine:1.5from
Open
Fix "FROM" with the specified database#80rodion-k wants to merge 10 commits intothecodingmachine:1.5from
rodion-k wants to merge 10 commits intothecodingmachine:1.5from
Conversation
…rapolation is off
homersimpsons
requested changes
Jul 29, 2023
Collaborator
homersimpsons
left a comment
homersimpsons
left a comment
There was a problem hiding this comment.
Thank you 🎉 Looks overall good.
Just 2 small comments. Also about PHPStan's output mabe you can find a way to restrict the types.
| * @return int | ||
| */ | ||
| public function key() | ||
| public function key(): mixed |
Collaborator
There was a problem hiding this comment.
I am not sure that we should introduce the mixed return type as this would require to target newer PHP version. What's your opinin on this ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.