Update deps + test on dbal v3#87
Conversation
- Updates dev deps - Fixes coverage in ci - Migrate phpunit config to newer schema - Ignore unmatched errors in phpstan - Adds asserts to fix phpstan errors - Fixes methods accessing dbal v3 - Use mysql80/postgressql10 platforms
|
@moufmouf This is another pr in a series of pr's to add support for dbal v3 in https://github.com/thecodingmachine/tdbm: thecodingmachine/schema-analyzer#13 |
homersimpsons
left a comment
homersimpsons
left a comment
There was a problem hiding this comment.
Thank you for your work on this! (sorry for the late review)
The changes are quite good!
| # Let's wait for MySQL 8 to start | ||
| sleep 20 | ||
|
|
||
| vendor/bin/phpunit -c phpunit.xml.dist $NO_COVERAGE |
There was a problem hiding this comment.
What is this $NO_COVERAGE variable ? Can you document it at the beginning of the file ?
There was a problem hiding this comment.
It's just a way to pass arguments to phpunit, NO_COVERAGE=--no-coverage, since it's a dev script, i don't think it's worth documenting
There was a problem hiding this comment.
It could just be a $PHPUNIT_ARG looking at the position? Or $PHPUNIT_EXTRA_ARG?
There was a problem hiding this comment.
@aszenz Thank you for your contribution to upgrade the whole TDBM stack to DBAL 3!
Released in https://github.com/thecodingmachine/magic-query/releases/tag/v2.0.0-beta.2
2 participants
After updating schema-analyzer in thecodingmachine/schema-analyzer#13
Follow up of 0c0ab13 to support v2 of schema analyzer