update rules for phpstan 2

[alekitto]

I've updated the rules to be compatible with phpstan 2, dropping the support for phpstan 1.

Rules now returns an array of objects (instance of RuleError) instead of strings.
Hints are now added to RuleError object using RuleErrorBuilder::tip method.

Fix #66

[mfn]

Very nice!

Since there's no github action implemented for this repo and I'm unable to see if the test suite was properly executed with this Scrutinizer, I checked out the code locally and let the test suite run -> all green \o/

~/src/phpstan-strict-rules ⎇ phpstan_v2
 $ vendor/bin/phpunit 
PHPUnit 9.6.22 by Sebastian Bergmann and contributors.

......                                                              6 / 6 (100%)

Time: 00:00.737, Memory: 68.00 MB

OK (6 tests, 6 assertions)

Generating code coverage report in Clover XML format ... done [00:00.001]

Generating code coverage report in HTML format ... done [00:00.011]


Code Coverage Report Summary:
  Classes: 100.00% (7/7)     
  Methods: 100.00% (14/14)   
  Lines:   100.00% (120/120) 

[mfn]

@shish I've seen you active on other repos here, do you have any plans/interest/permission to also handle this repo? Or do you know who can?

[alekitto]

Since there's no github action implemented for this repo ...

I've implemented a gha workflow on my fork to test if everything works. I can send that too (in a separate PR)

[shish]

do you have any plans/interest/permission to also handle this repo

I was only given access to safe and phpstan-safe-rule -- as far as I'm aware it's only the TCM team themselves who have access to this repo, and they seem very focussed on whatever it is they're doing 😓

[mfn]

Honest / friendly question: should we fork it?

Those who are using it are locked from upgrading to Laravel 12.

[alekitto]

Honest / friendly question: should we fork it?

I needed this for my projects, I've forked it (https://packagist.org/packages/kcs/phpstan-strict-rules).
If this will be merged soon, I'll delete the fork, otherwise I can maintain it under a new name.