Multiple Connections: Correctly inject code generators#21
Merged
gulien merged 2 commits intothecodingmachine:masterfrom Feb 1, 2021
Merged
Conversation
Technically we do use tags and interface implementations to do this automatically
Member
|
Excellent! 👍 We might want to move from Travis to Github Action to enable CI again. Did you try phpunit locally? Does it work? |
Collaborator
Author
|
Yes PHPUnit runs fine locally. But this specific part is untested, I know vaguely how to test (declare a service implementing the interfaces and check that thoses are well wired to the configuration) but I do not know how to make this test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technically we do use tags and interface implementations to do this automatically