Skip to content

Comments

Fix/deeper composite fk#230

Merged
moufmouf merged 4 commits intothecodingmachine:5.1from
homersimpsons:fix/deeper_composite_fk
Sep 30, 2020
Merged

Fix/deeper composite fk#230
moufmouf merged 4 commits intothecodingmachine:5.1from
homersimpsons:fix/deeper_composite_fk

Conversation

@homersimpsons
Copy link
Collaborator

Fixes #207

This fixes a corner case in serialization code about a schema looking like:

  summary_tdh  |  summary     |  entity
  entity_id   <=> entity_id  <=> entity_id
  summary_id  <=> summary_id

Where <=> reflects a Foreign Key

@coveralls
Copy link

coveralls commented Sep 24, 2020

Coverage Status

Coverage increased (+0.006%) to 97.187% when pulling 9d060fc on homersimpsons:fix/deeper_composite_fk into a20710b on thecodingmachine:5.1.

@moufmouf
Copy link
Member

There seems to be a PHPStan issue to solve and this should be all right!

@moufmouf
Copy link
Member

👍

@moufmouf moufmouf merged commit 5a7bb2e into thecodingmachine:5.1 Sep 30, 2020
@moufmouf
Copy link
Member

@homersimpsons Can you backport this to the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants