I'm seeing an issue when fdir@6.5.0 is bundled using esbuild.

[Jason3S]

I'm seeing an issue when fdir@6.5.0 is bundled using esbuild.

Generated code:

// ../../../../node_modules/.pnpm/fdir@6.5.0_picomatch@4.0.3/node_modules/fdir/dist/index.mjs
var import_module = require("module");
var import_path2 = require("path");
var nativeFs = __toESM(require("fs"), 1);
var import_meta2 = {};
var __require = /* @__PURE__ */ (0, import_module.createRequire)(import_meta2.url);
function cleanPath(path14) {
  let normalized = (0, import_path2.normalize)(path14);
  if (normalized.length > 1 && normalized[normalized.length - 1] === import_path2.sep) normalized = normalized.substring(0, normalized.length - 1);
  return normalized;
}

error:

node:internal/modules/cjs/loader:1895
    throw new ERR_INVALID_ARG_VALUE('filename', filename, createRequireError);
          ^

TypeError [ERR_INVALID_ARG_VALUE]: The argument 'filename' must be a file URL object, file URL string, or absolute path string. Received undefined
    at createRequire (node:internal/modules/cjs/loader:1895:11)
    at Object.<anonymous> (/Users/jason/projects/cspell/test-packages/cspell/test-cspell-esbuild-cjs/bin/dist/index.cjs:42093:65)
    at Module._compile (node:internal/modules/cjs/loader:1692:14)
    at Object..js (node:internal/modules/cjs/loader:1824:10)
    at Module.load (node:internal/modules/cjs/loader:1427:32)
    at Module._load (node:internal/modules/cjs/loader:1250:12)
    at TracingChannel.traceSync (node:diagnostics_channel:322:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
    at Module.require (node:internal/modules/cjs/loader:1449:12)
    at require (node:internal/modules/helpers:135:16) {
  code: 'ERR_INVALID_ARG_VALUE'
}

Originally posted by @Jason3S in #147 (comment)

[Jason3S]

The workaround is: evanw/esbuild#1492 (comment)

What was the win in making an ESM version?

[TheAlexLichter]

@Jason3S It is dual published, so you can still use CJS.

The ESM version has their import time decreased by 1.5~1.66x, see #147 (comment)

[Jason3S]

@TheAlexLichter,

Thank you.

Since it is a nested dependency, I don't have control over the import, so using the .cjs isn't really an option. I raised the issue since it broke one of my CI/CD tests that ensures bundling works.

[TheAlexLichter]

@TheAlexLichter,

Thank you.

Since it is a nested dependency, I don't have control over the import, so using the .cjs isn't really an option. I raised the issue since it broke one of my CI/CD tests that ensures bundling works.

IMO it would be best to raise that in the dep that uses fdir then 🤔

[Jason3S]

@TheAlexLichter,
Thank you.
Since it is a nested dependency, I don't have control over the import, so using the .cjs isn't really an option. I raised the issue since it broke one of my CI/CD tests that ensures bundling works.

IMO it would be best to raise that in the dep that uses fdir then 🤔

Why? It is an ESM package.

The issues is the way picomatch is required. I understand that it is done this way to avoid having a hard requirement on a specific version of picomatch.

Are you interested in a PR that fixes the issue?