Skip to content

Add Jack's pfp to about page#1132

Merged
artiehumphreys merged 2 commits intodevfrom
jack-profile-pic
Nov 9, 2025
Merged

Add Jack's pfp to about page#1132
artiehumphreys merged 2 commits intodevfrom
jack-profile-pic

Conversation

@jackrhoa
Copy link
Collaborator

@jackrhoa jackrhoa commented Sep 21, 2025

Summary by CodeRabbit

  • New Features

    • Added Jack Rhoa (Developer, Class of 2028) to the Engineering Team page. His profile, including a profile image and GitHub link, is now visible alongside existing members.
  • Chores

    • Updated team data to include the new member; no other entries were changed and there are no behavior or UI regressions.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 21, 2025

Walkthrough

Adds a new engineering_team entry for Jack Rhoa to tcf_website/views/team_info.json; only data content changed, no behavior or control flow modified.

Changes

Cohort / File(s) Summary of Changes
Team data update
tcf_website/views/team_info.json
Appended a new object for "Jack Rhoa" (role: Developer, class: 2028) with img_filename and github fields. No other entries were modified or removed.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • Jay-Lalwani

Poem

A rabbit scampers to join the log,
Jack’s in the JSON, snug as a cog. 🥕
Fields aligned, commas in tune,
A tiny hop beneath the moon.
Ship it soft — and code, commune.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided by the author. The repository has a description template with required sections (GitHub Issues addressed, What I did, Screenshots, Testing, Questions/Discussions/Notes) that are completely missing. Add a pull request description following the template, including which GitHub issue this closes, what was changed, before/after context, and testing information.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Jack's pfp to about page' accurately describes the main change: adding Jack Rhoa's profile picture (image file) to the team info on the about page.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch jack-profile-pic

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6a3038a and f7485ae.

📒 Files selected for processing (1)
  • tcf_website/views/team_info.json (1 hunks)
🔇 Additional comments (1)
tcf_website/views/team_info.json (1)

291-297: Image file verified; JSON entry is correct and ready to merge.

The referenced image file ENG_Jack_Rhoa.jpg exists at tcf_website/static/about/team-pfps/. The new Jack Rhoa entry is properly formatted, consistent with existing team entries, and all required fields are populated correctly.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
tcf_website/views/team_info.json (2)

127-132: Unrelated nit: key typo "role:" breaks schema consistency.

This existing entry uses "role:" (with a colon in the key) instead of "role". If consumers read "role", this person’s role may not render.

Apply:

-      "name": "Kingsley Kim",
-      "role:": "Developer",
+      "name": "Kingsley Kim",
+      "role": "Developer",

Consider a quick follow-up PR.


267-267: Optional: prefer WebP for perf.

If your build/static hosting supports it, consider using WebP (e.g., ENG_Jack_Rhoa.webp) to reduce payload on the About page.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e37a946 and 6a3038a.

⛔ Files ignored due to path filters (1)
  • tcf_website/static/about/team-pfps/ENG_Jack_Rhoa.jpg is excluded by !**/*.jpg
📒 Files selected for processing (1)
  • tcf_website/views/team_info.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: pylint
  • GitHub Check: django
🔇 Additional comments (1)
tcf_website/views/team_info.json (1)

263-269: LGTM — JSON valid; image present; no duplicate entry.

jq validated tcf_website/views/team_info.json; image located at tcf_website/static/about/team-pfps/ENG_Jack_Rhoa.jpg; single "Jack Rhoa" occurrence (line 264).

@artiehumphreys artiehumphreys self-requested a review November 9, 2025 17:20
Copy link
Member

@artiehumphreys artiehumphreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artiehumphreys artiehumphreys merged commit ff9f494 into dev Nov 9, 2025
4 checks passed
@artiehumphreys artiehumphreys deleted the jack-profile-pic branch November 9, 2025 17:20
@coderabbitai coderabbitai bot mentioned this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants