Dashboard Stabilization & Payments Hardening - Tracking

[thefiredev-cloud]

Prioritized Checklist

Blockers

• Checkout discount application → NP12345 should yield $0.00 and immediate dashboard access → currently reports partial balance and leaves user in pending state → ensure promotion logic zeroes total and bypasses payment-required gates
• Checkout discount application → MENTO12345 should apply 99.9% reduction and surface updated total in UI → currently shows full price and fails on confirmation → wire promotion code lookup and totals display
• Idempotent checkout retries → retries should not throw idempotency_error → currently duplicate attempts fail after partial session creation → derive idempotency keys from hashed payload
• Intake progression gating → completing intake should unlock matching/dashboard routes → today users loop back to intake → repair RoleGuard and completion flag propagation

Core UX

• Student dashboard messaging composer → send button should dispatch Convex mutation and show toast → currently no-op → wire mutation + optimistic update
• Student billing history → "View billing portal" should open Stripe portal and list past invoices → button inert → connect to portal session API and render history table
• Admin finance filters & CSV → filters should drive query and CSV export button should download latest dataset → controls idle → connect Convex queries/actions and surface toast feedback
• Admin discount setup toggle → 99.9% discount button should show live status → now static → hook to promotion creation mutation and reflect state
• Preceptor dashboard match actions → accept/decline should update match and show toast → buttons disabled → wire mutations and optimistic state
• Notification-driven navigation → clicking notification should deeplink to match detail → now reloads dashboard root → fix router push + mark-read mutation

Nice-to-have

• Loading/skeleton states across dashboards → skeletons should replace blank panels → currently flashes empty divs → add skeleton components and aria labels
• Toast and error surfacing → success/failure should be confirmed visibly → now silent → standardize toast helpers
• E2E data-testids → selectors should rely on deterministic ids → currently brittle → add data-testid attributes to critical actions

Repro Steps

1. Checkout codes
   • Log in as student, progress to checkout
   • Apply NP12345 or MENTO12345
   • Observe price mismatch and failed completion
2. Intake loop
   • Complete required intake steps
   • Attempt to open /dashboard/student
   • Note redirect back to intake flow
3. Student messages
   • Open student dashboard messages panel
   • Enter text and click "Send"
   • Console shows no network call, message not persisted
4. Admin CSV export
   • Navigate to admin finance view
   • Adjust filters and click "Export CSV"
   • Button does nothing, no download initiated
5. Preceptor match actions
   • Open preceptor dashboard matches list
   • Click "Accept" or "Decline"
   • Button remains disabled and no toast appears

Acceptance Criteria

• Discounts NP12345 and MENTO12345 reliably update totals, succeed end-to-end, and grant access without manual intervention
• Checkout flow produces deterministic idempotency keys; repeated submissions succeed without idempotency_error
• Intake completion flips access flag and RoleGuard routes users correctly per role
• Dashboard actions (messages, billing, finance filters, match actions) trigger Convex mutations/actions, update UI optimistically, and surface success/error toasts
• Loading, empty, and error states display accessible skeletons/placeholders; no console errors in happy paths
• Stripe, Netlify, and Sentry telemetry verified clean after fixes (no new dashboard-route errors)
• Playwright happy-path coverage exists for checkout (both codes), messaging send/read, and admin discount init

Local & CI Commands

npm run type-check
npm run lint
npm run test:unit:run
npm run test:e2e

[thefiredev-cloud]

Phase 1 (Dead-Feature Sweep) – Findings

Core UX gaps

• Student profile "Save Changes" (app/dashboard/student/profile/page.tsx) only toggles edit mode and never persists data; needs controlled form state + Convex update mutation and toasts.
• Preceptor dashboard "Send Update" button (app/dashboard/preceptor/students/page.tsx) is inert; should launch a messaging flow wired to api.messages mutations with optimistic toast.
• Admin email telemetry controls (Filter/Refresh/Retry in app/dashboard/admin/emails/page.tsx) are placeholders; wire filter state into the query, re-trigger fetch, and add a retry mutation.
• Admin SMS telemetry controls (Filter/Refresh/Retry in app/dashboard/admin/sms/page.tsx) mirror the same gap; add filter wiring + resend action + feedback.

Nice-to-have / polish

• Preceptor "Quick Actions" buttons (Export Reports, Add Evaluations, View Analytics, Send Messages, Generate Reports) have no handlers; map each to existing routes or stub modals with TODO toasts.
• Admin finance transaction "More" menu (app/dashboard/admin/finance/page.tsx) is just an icon button; replace with a dropdown exposing invoice/refund actions backed by api.payments mutations.

No new blockers surfaced beyond the checkout/discount items already logged. Let me know if you want any of these prioritized differently before I start wiring the first set (plan is to tackle student profile persistence next).

[thefiredev-cloud]

✅ Student profile "Save Changes" now persists data.

• Added students.updateProfileBasics mutation (convex/students.ts) to merge partial personal/school updates with proper auth checks and timestamping.
• Student profile page uses controlled form state, validation, and the new mutation; save CTA now shows loading, success toast, and handles "no change" cases (app/dashboard/student/profile/page.tsx).
• Type-check + lint green.

Next up: preceptor "Send Update" wiring unless higher priority comes up.

[thefiredev-cloud]

✅ Preceptor dashboard "Send Update" now delivers bulk messages to active students.

• Replaced the mock student list with live data from Convex (api.matches.getActiveStudentsForPreceptor) and derived per-student cards from real match records.
• Added a modal workflow for the "Send Update" CTA that fans out the composed message by calling messages.getOrCreateConversation + messages.sendMessage for each active match, with loading state and toasts (app/dashboard/preceptor/students/page.tsx).
• Minor quality-of-life polish while wiring: the student profile cards now fall back gracefully when data is missing, and the bulk-send action disables when there are no active matches.

Lint + type-check remain clean.

[thefiredev-cloud]

Polished the admin email telemetry view:

• Added status and template filters plus quick clear; wired Refresh to the live query so we can rehydrate without reloading (app/dashboard/admin/emails/page.tsx).
• Surfaced empty states when filters return no rows and hooked the Retry button to a new Convex action that marks the log pending for reprocessing (convex/emails.ts, app/dashboard/admin/emails/page.tsx).
• Lint + type-check still clean.