Add server_max_queued_requests and server_max_retry_delay parameters#570
Add server_max_queued_requests and server_max_retry_delay parameters#570mmoll merged 1 commit intotheforeman:masterfrom syseleven:feature/add-max-queued-requests-and-max-retry-delay
server_max_queued_requests and server_max_retry_delay parameters#570Conversation
mmoll
left a comment
mmoll
left a comment
There was a problem hiding this comment.
This only works for Puppetserver >= 5.1, so there needs to be an added version check
|
@baurmatt, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:
If changing the ticket number used, remember to update the PR title and the commit message (using This message was auto-generated by Foreman's prprocessor |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Yes of course -.- It should now be fixed. Edit: Not sure what @theforeman-bot wants from me :D |
|
@baurmatt, the Redmine ticket used is for a different project than the one associated with this GitHub repository. Please either:
If changing the ticket number used, remember to update the PR title and the commit message (using This message was auto-generated by Foreman's prprocessor |
|
We have the convention that #xxx refers to our Redmine issues while GH-xxx refers to Github issues. Could you amend the commit message to use that syntax? |
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
Ah, yeah sure. Its fixed now :) |
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
Other than the testing code (only mentioned once) it looks good.
| ) | ||
| end | ||
| it 'should have max-queued-requests: 0' do | ||
| content = catalogue.resource('file', '/etc/custom/puppetserver/conf.d/puppetserver.conf').send(:parameters)[:content] |
There was a problem hiding this comment.
We have a verify_content for this, or the regular expected.to contain_file('/etc/custom/...').with_content(/^ max-queued-requests: 0$/) should work.
There was a problem hiding this comment.
I've just copied it from another test in this file, seems like there are a lot of options which are used in those tests ;) Switched to expected.to contain_file... :)
This commit adds support for queueing and retrying requests if the Puppet Server is busy. https://puppet.com/docs/puppet/5.3/release_notes.html#new-feature-puppet-agents-can-retry-requests-on-a-configurable-delay-if-puppet-server-is-busy Fixes GH-569
theforeman-bot
added
Needs re-review
Needs testing
and removed
Waiting on contributor
labels
|
merged, danke @baurmatt! |
4 participants
This commit adds support for queueing and retrying requests if the Puppet
Server is busy.
https://puppet.com/docs/puppet/5.3/release_notes.html#new-feature-puppet-agents-can-retry-requests-on-a-configurable-delay-if-puppet-server-is-busy
Fixes GH-569