add compile_mode parameter to puppetserver.conf#574
add compile_mode parameter to puppetserver.conf#574mmoll merged 1 commit intotheforeman:masterfrom miksercz:master
Conversation
|
I am not sure how could my simple change fail so many tests - will take a closer look at it, when I have the time. |
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
We test the class in spec/classes/puppet_server_puppetserver_spec.rb and set all the parameters explicitly. Please add the variable to default_params there as well.
Other than that I think it looks good.
manifests/init.pp
Outdated
| Optional[Array] $server_metrics_allowed = $::puppet::params::server_metrics_allowed, | ||
| Boolean $server_puppetserver_experimental = $puppet::params::server_puppetserver_experimental, | ||
| Array[String] $server_puppetserver_trusted_agents = $puppet::params::server_puppetserver_trusted_agents, | ||
| Variant[Undef, Enum['off'], Enum['jit'], Enum['force']] $server_compile_mode = $puppet::params::server_compile_mode, |
There was a problem hiding this comment.
This type can be Optional[Enum['off', 'jit', 'force']]
manifests/server.pp
Outdated
| Variant[Undef, Array] $metrics_allowed = $::puppet::server_metrics_allowed, | ||
| Boolean $puppetserver_experimental = $::puppet::server_puppetserver_experimental, | ||
| Array[String] $puppetserver_trusted_agents = $::puppet::server_puppetserver_trusted_agents, | ||
| Variant[Undef, Enum['off'], Enum['jit'], Enum['force']] $compile_mode = $::puppet::server_compile_mode, |
theforeman-bot
added
Waiting on contributor
Needs re-review
Needs testing
and removed
Not yet reviewed
Waiting on contributor
labels
|
Looks correct, but I'll let Travis finish before approving. |
|
@ekohl I believe I named the variable incorrectly in the spec test, it should be called |
|
Problems fixed, commits squashed, please let me know if there's any more changes I should do. |
|
looks good, merged, díky @miksercz! |
4 participants
Hello,
recently I wanted to try setting puppetserver's compile-mode to some value other than default, your module doesn't as of yet have this functionality. This PR should add it.